Add some tests for debug info behavior #24650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the behavior being discussed in emscripten-core#20462 Also decouple settings.DEBUG_LEVEL (which is the final debug level output) from cases where we just need e.g. intermediate DWARF. This will hopefully make cases like "full optimizations + source maps" more clear.
|
Did you want to land this? |
dschuff
commented
Jul 16, 2025
| (['-O2', '-g'], True, False, True, False), | ||
| (['-O2', '--closure=1'], False, True, False, True), | ||
| (['-O2', '--closure=1', '-g1'], False, True, True, True), | ||
| for args, expect_clean_js, expect_whitespace_js, expect_closured in [ |
There was a problem hiding this comment.
lines 9200, 9202, and 9203 are new, the rest are the removal of the unused 'expect_clean_js' parameter.
There was a problem hiding this comment.
Was "expect_clean_js" a typo of "expect_emit_text"? (the latter seems to be the one removed)
There was a problem hiding this comment.
Yes, expect_emit_text was unused.
kripken
approved these changes
Jul 16, 2025
cwoffenden
pushed a commit
to cwoffenden/emscripten
that referenced
this pull request
Jul 19, 2025
In particular, the behavior being discussed in emscripten-core#20462 Also decouple settings.DEBUG_LEVEL (which is the final debug level output) from cases where we just need e.g. intermediate DWARF. This will hopefully make cases like "full optimizations + source maps" more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the behavior being discussed in #20462
Also decouple settings.DEBUG_LEVEL (which is the final debug
level output) from cases where we just need e.g. intermediate DWARF.
This will hopefully make cases like "full optimizations + source maps"
more clear.